-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Enable metrics of clientgo leader election #1901
Conversation
Welcome @zqzten! |
Hi @zqzten. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution 🥇
I updated the first comment to try to clarify the questions made as well. I hope that you like it. However, please feel free to change.
Could you rebase the commits so we can move forward?
Otherwise, it shows for me
/lgtm
@varshaprasad96 @alvaroaleman wdyt?
@camilamacedo86 Thanks for the clarification, it looks better👍. Code is rebased. |
/assign @joelanford |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Friendly ping @joelanford for approval or further comments |
@zqzten please make seperate PRs for removing the metrics and adding new ones so both the changes appear in the changelog |
@alvaroaleman Okay, I've seperated the removal to #1946, PTAL. |
@alvaroaleman Could you also help approve this PR? It seems that there's no response from other assignees for some time. Thanks! |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale @alvaroaleman @joelanford Need lgtm approve here, thanks! |
/lgtm @alvaroaleman @joelanford @vincepri Can we move with this one? |
@@ -633,6 +636,7 @@ func (cm *controllerManager) startLeaderElection(ctx context.Context) (err error | |||
}, | |||
}, | |||
ReleaseOnCancel: cm.leaderElectionReleaseOnCancel, | |||
Name: cm.leaderElectionID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TILd Label values may contain any unicode character
, ref https://prometheus.io/docs/concepts/data_model/ so we don't have to sanitize this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, camilamacedo86, zqzten The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR enables metrics of clientgo leader election ( "k8s.io/client-go/tools/leaderelection" )